[Jenkins-infra] Improvement proposal for jenkinsci/jenkins repo review process

Daniel Beck ml at beckweb.net
Mon Oct 5 12:00:47 UTC 2015


The problem here is that only people with repo write access are allowed to change labels. So you updated your PR and want to label it accordingly? Only if you didn't need to file a PR in the first place.

On 05.10.2015, at 12:59, Oleg Nenashev <o.v.nenashev at gmail.com> wrote:

> Hello,
> 
> There are many open PRs in Jenkins core repo. Currently it's very hard to perform reviews, because for every PR you need to go into and to see the current status by going through the conversation. It would be great so somehow show current statuses in the PR list.
> 
> I propose to add the following labels:
> 	• needs-review (dark yellow)
> 	• needs-fix (orange)
> 	• needs-testcase (light orange)
> 	• needs-docs (ligh orange)
> 	• ready-for-merge (violet)
> 		• Indicates that the PR has passed the review (e.g. "+1s and no responses during several days")
> 		• A merger can merge the PR & squash it
> A similar approach is being used in Jenkins CERT team for a while. It seems to be effective. 
> 
> The approach could be also used in plugins. In the long-term it may be possible to add overall PR status dashboards, which may be helpful for the project.
> 
> If there is no concerns, I'll go forward and add labels.
> 
> Best regards, Oleg
> 
> _______________________________________________
> Jenkins-infra mailing list
> Jenkins-infra at lists.jenkins-ci.org
> http://lists.jenkins-ci.org/mailman/listinfo/jenkins-infra



More information about the Jenkins-infra mailing list