[Jenkins-infra] Improvement proposal for jenkinsci/jenkins repo review process

Tom Fennelly tom.fennelly at gmail.com
Mon Oct 5 11:51:11 UTC 2015

I'm not sure about all of the labels, but +1 for the PR owner to be allowed 
(if they wish) perform a PR squash once the review has been completed.

I'm not even sure that was ever an agreed upon "rule" (thou shalt not 
squash), but I do know there are people for and against it and nobody is 
right (imo), so it should be the choice of the PR owner to do it or not 
(without getting badgered either way).

On Monday, October 5, 2015 at 11:59:15 AM UTC+1, Oleg Nenashev wrote:
> Hello,
> There are many open PRs in Jenkins core repo. Currently it's very hard to 
> perform reviews, because for every PR you need to go into and to see the 
> current status by going through the conversation. It would be great so 
> somehow show current statuses in the PR list.
> I propose to add the following labels:
>    - needs-review (dark yellow)
>    - needs-fix (orange)
>    - needs-testcase (light orange)
>    - needs-docs (ligh orange)
>    - ready-for-merge (violet)
>       - Indicates that the PR has passed the review (e.g. "+1s and no 
>       responses during several days")
>       - A merger can merge the PR & squash it
> A similar approach is being used in Jenkins CERT team for a while. It 
> seems to be effective. 
> The approach could be also used in plugins. In the long-term it may be 
> possible to add overall PR status dashboards, which may be helpful for the 
> project.
> If there is no concerns, I'll go forward and add labels.
> Best regards, Oleg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.jenkins-ci.org/pipermail/jenkins-infra/attachments/20151005/a98acd97/attachment-0001.html>

More information about the Jenkins-infra mailing list