[Jenkins-infra] (fwd) HEADSUP: Breaking change for Docker Pipelines coming on ci.jenkins.io

[R. Tyler Croy]

Just FYI for posterity

----- Forwarded message from "R. Tyler Croy" <tyler at monkeypox.org> -----

Date: Mon, 2 Apr 2018 06:52:00 -0700
From: "R. Tyler Croy" <tyler at monkeypox.org>
To: jenkinsci-dev at googlegroups.com
Subject: HEADSUP: Breaking change for Docker Pipelines coming on ci.jenkins.io
Message-ID: <20180402135200.v2ek6zwq76ld4enb at blackberry.coupleofllamas.com>
List-Archive: <https://groups.google.com/group/jenkinsci-dev


I have put this off as long as I feel prudent, but later this week I will be
upgrading the Docker Pipeline plugin on ci.jenkins.io from 1.14 to 1.15.1 which
will break Docker Pipelines which rely on the implicit ENTRYPOINT override
behavior which was supposed in 1.14, but removed for 1.15.1
(https://issues.jenkins-ci.org/browse/JENKINS-41316).

I know at least the jenkinsci/docker Pipeline will break due with invocations
such as this one:
    https://github.com/jenkinsci/docker/blob/master/Jenkinsfile#L21
See also:
    https://github.com/koalaman/shellcheck/blob/master/Dockerfile#L36


From my understanding, the remediation for this upgrade/regression (depending
on your perspective) is to execute:

    docker.image('foo').inside('--entrypoint= ') {
        sh 'blah'
    }


It is not easily knowable what the size and impact of this change is going to
be, so I'm sending this heads up out.

If you have a Jenkinsfile in ci.jenkins.io that relies on
docker.image().inside() or the equivalent in Declarative Pipeline, that
Pipeline may *break* starting on Thursday, April 5th.



Cheers
- R. Tyler Croy

------------------------------------------------------
     Code: <https://github.com/rtyler>
  Chatter: <https://twitter.com/agentdero>
     xmpp: rtyler at jabber.org

  % gpg --keyserver keys.gnupg.net --recv-key 1426C7DC3F51E16F
------------------------------------------------------

-- 
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe at googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/20180402135200.v2ek6zwq76ld4enb%40blackberry.coupleofllamas.com.
For more options, visit https://groups.google.com/d/optout.



----- End forwarded message -----

- R. Tyler Croy

------------------------------------------------------
     Code: <https://github.com/rtyler>
  Chatter: <https://twitter.com/agentdero>
     xmpp: rtyler at jabber.org

  % gpg --keyserver keys.gnupg.net --recv-key 1426C7DC3F51E16F
------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.jenkins-ci.org/pipermail/jenkins-infra/attachments/20180402/d360024b/attachment.asc>