[Jenkins-infra] Requesting PR reviews from anyone in the jenkinsci organization

Baptiste Mathus ml at batmat.net
Tue Feb 20 13:41:16 UTC 2018


For some reason, it does not work, and wasn't before either for me. Not
everywhere at least, and not being admin, I couldn't check/understand why.
For instance, I still cannot request myself a review on https://github.com/
jenkinsci/configuration-as-code-plugin/pull/43

Maybe it's just because some/many plugins set the permissions differently
from the average, so it will work randomly depending on the conf of a given
plugin?

Should we make this a part/clarification in a JEP (?) about plugin hosting
/rules/?

2018-02-19 23:26 GMT+01:00 Oleg Nenashev <o.v.nenashev at gmail.com>:

> I wonder whether it also resolves the issue with mentioning code-reviewers
>
> 2018-02-19 23:18 GMT+01:00 Daniel Beck <ml at beckweb.net>:
>
>> Hi everyone,
>>
>> One of the benefits of the Everyone team was that most members of the
>> GitHub org could be requested as reviewers. Now, with the migration from
>> Everyone to collaborators[1], that functionality was completely gone,
>> hindering collaboration.
>>
>> I now learned that changing the default member privileges for the
>> jenkinsci org from 'None' to 'Read' would allow any org member to be
>> requested as reviewer. I've changed this a few minutes ago accordingly.
>> Since the jenkinsci org exclusively has public repos, there should be no
>> other impact.
>>
>> If you experience any problems because of the above change, please file
>> an INFRA issue for the github component.
>>
>> Daniel
>>
>> [1]: https://groups.google.com/d/msg/jenkinsci-dev/ksKAsmsmVng/Gy
>> Z6EQjmAAAJ
>>
>> _______________________________________________
>> Jenkins-infra mailing list
>> Jenkins-infra at lists.jenkins-ci.org
>> http://lists.jenkins-ci.org/mailman/listinfo/jenkins-infra
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscribe at googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/ms
> gid/jenkinsci-dev/CAPfivLCNgreywE_X%2BGtVL1Ytb_2RUB1oSFLFq2v
> okg-CQRedsA%40mail.gmail.com
> <https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCNgreywE_X%2BGtVL1Ytb_2RUB1oSFLFq2vokg-CQRedsA%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>
> For more options, visit https://groups.google.com/d/optout.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.jenkins-ci.org/pipermail/jenkins-infra/attachments/20180220/4a860d85/attachment.html>


More information about the Jenkins-infra mailing list